4.1 UI Changes?

UI and Macro
So I just checked the 4.1 PTR Patch Notes and saw a few UI changes listed, however, upon trying to login all my addons I have that reference COMBATLOG_OBJECT constants are blowing up all over the place. I didn't see anything related to this in the patch notes, and the constants still exist in the proper files, so not sure what's up here. So was curious if anyone had a more "complete" list of 4.1 UI changes, so I can try and track down what's going on here.
No such list has been made available yet.
Found the change

-function CombatLog_OnEvent(filterSettings, timestamp, event, sourceGUID, sourceName, sourceFlags, destGUID, destName, destFlags, ...)
+function CombatLog_OnEvent(filterSettings, timestamp, event, hideCaster, sourceGUID, sourceName, sourceFlags, destGUID, destName, destFlags, ...)

They added an additional parameter (in the middle none the less) to the combatlog events.

So I was getting lots and lots of errors as all the addons that hook the combat log we're getting the sourceName instead of the sourceFlags and bit.band blows up if you pass it a string. :-)

The only other change I ran into that caused any problems was they removed the global NUM_WORLDMAP_DETAIL_TILES and replaced it with an API call GetNumberOfDetailTiles()
I should have noted earlier that you can start the client in console mode and dump the UI files.
02/25/2011 9:24 AMPosted by Unkle
I should have noted earlier that you can start the client in console mode and dump the UI files.


I already had and ran a diff, it's just the error I was getting was in relation to constants, however I was mis-reading the error and didn't realize the problem was with the srcFlags not the constants, so I was looking at the wrong thing.

Join the Conversation

Return to Forum