Topic
Inspect
|
Hello guys, I'm writing because since cata launched I've had problems inspecting other players.
the problem: *I inspect a player and they don't have any gear. *inspected player has different talent trees example: i'll be inspecting a warrior and he will have druid talent trees. *Gear from inspected players (when it does show up) has no stats, only generic names like "chest piece". I don't know if its an addon i have thats messing up the inspect or what, but it's buggin the hell out of me :S Thanks in advanced. Buggeroff. |
|
I'm also having this problem and I don't know what's causing it. It seems to be an addon problem but I was hoping someone could tell me so I don't have to turn them off one by one.
|
|
With each new patch changes are made to the blizzard UI that can break third party UI mods and cause any number of problems in the client. |
|
Edited by Aster on 2/22/12 4:10 PM (PST)
Hi folks. The bug where you are seeing the wrong information for the person you are inspecting is a simple bug in the Blizzard code.
On line 18 of InspectPaperDollFrame.lua (re-extracted today to make sure I was looking at the most current version), the section of code that responds to the INSPECT_READY event does not check if the unit the event refers to is the same one that the frame is meant to be showing. The code directly above this that responds to UNIT_MODEL_CHANGED and to UNIT_LEVEL is wrapped in an if statement that DOES perform this check, comparing the unit passed with the event to the one stored when the InspectFrame was opened, i.e. InspectFrame.unit. Because the INSPECT_READY event does not carry the unit as an argument, but rather the GUID, the section responding to INSPECT_READY had to be left outside of that 'if' block. But that section also does not perform that check for itself. The result is that if any addon requests inspect data while you have this frame up, the Blizzard code will show the hunter you were looking at as specc'd holy and wearing cloth. This bug is probably a remnant from when the inspect events did not carry any information about the unit the inspect information was for. Those were messy days for using the inspect API. Since 4.01 the INSPECT_READY event comes with the GUID of the unit whose inspect data has become available. Fixing the bug is as trivial as changing line 18 from: if (event == "INSPECT_READY") then to if (event == "INSPECT_READY") and (UnitGUID(InspectFrame.unit) == unit) then This looks odd because the first argument after the event name is given the identifier 'unit' in this function, as that is what it is for the other two events handled; but for this event it is a GUID. For the moment, your best bet is to use a small addon called InspectFix, which blocks addons from performing inspects in the background whenever the Inspect UI is open. This is not ideal. Some addons depend on making sure that their inspect data is up to date when combat starts, and they could be blocked from accomplishing that. Nonetheless, until this bug is fixed, that is your best bet. Any attempt to argue that this is only broken when certain addons are loaded is tremendously disingenuous. Fix this small error and addons can continue to perform inspects as needed. Don't fix it and they can't. All addons out there that perform inspects are expected to, have to, and do check that they are collecting data for the correct unit, but this bit of Blizzard code does not. Anyhow, like I said, InspectFix is probably your best bet for now. |
|
Never had this problem, the only add-on I use is re-count, hope this helps
|
|
Your contention that a one-line fix to the blizzard code can fix the problem is naive. Your proposed fix would just break the inspect window in other subtle ways. The entire design of that Blizzard module currently assumes exclusive use of NotifyInspect.
For the moment, your best bet is to use a small addon called InspectFix, which blocks addons from performing inspects in the background whenever the Inspect UI is open. This is not ideal. Some addons depend on making sure that their inspect data is up to date when combat starts, and they could be blocked from accomplishing that. Nonetheless, until this bug is fixed, that is your best bet. Any such addons already have to be prepared for inspects to fail when the player is a few yards out of range, or when the server decides to throttle inspect requests. So any such addons that depend on inspect working for any unit at any time are already broken. InspectFix basically simulates throttling of inspect requests from any addons while the user is busy using the inspect window, ensuring sane behavior. |
