What Profession would be the best for a Warlock & also which ones will make the most money
(running low on money)
Gathering professions are always the most lucrative at low levels.
The easiest 3 to make money are skinning, herbalism and mining. You can make good money at low levels because most high levels have more gold than time and are willing to pay well for low level mats.
A stack of copper ore or a stack of light leather will usually fetch a few gold, depending on your server. Even herbs usually sell for a gold or more a stack for the beginning herbalist.
I'd suggest going to the AH and look up the going prices for copper and iron ore, light, medium, and heavy leather, and some different herbs, then choosing one or two of those professions. You'll have more than enough gold in no time!
As far as benefits, skinning earns you crit rating, herbalism earns you a small heal and some haste, as well as making potions more powerful when you use them. These are good side benefits for warlocks.
Threats of violence. We take these seriously and will alert the proper authorities.
Posts containing personal information about other players. This includes physical addresses, e-mail addresses, phone numbers, and inappropriate photos and/or videos.
Harassing or discriminatory language. This will not be tolerated.